search

stujones11 / shooter

First Person Shooter Mod for Minetest
Other
30 stars 18 forks source link

Separate weapons and API #21

Closed BrunoMine closed 5 years ago

BrunoMine commented 7 years ago

I would like this API to be used as support for other mods. I like this API, but it's undesirable to have all those weapons on the server. I would like to separate each weapon into a special mod and the API as well. If this is done, I to do all the work.

Weapons are as complex as mobs in minetest. I believe this can get better with the API new minetest features

stujones11 commented 7 years ago

I do plan to overhaul this mod a some stage but I think it will be for the minetest 0.5.x series which will hopefully include better ray-casting features. I will keep your comments in mind and try to make the weapons more modular.

BrunoMine commented 7 years ago

Would you accept a PR? Maybe I can help you do that. But maybe you do not like big interferences in your mod.

stujones11 commented 7 years ago

I do not mind you making simple changes that will not break existing server installations, however, I do not have much time to test or review big changes at the moment. Also keep in mind that I may completely re-write the core eventually and do not want to waste your time.

BrunoMine commented 7 years ago

If we correctly plan what needs to be done, there will be no need to remove anyone's work. Are you willing to help with detailed change planning? I will carry out the changes gradually, to facilitate discussion, testing and follow-up. I still think you should consider the aids better as it would be a huge waste of time if I have to create an API. No matter how big plans you have for this project, with code reuse and refinement, the result will always be better.

About the server crash. (initiating a discussion about what we will do) If we separate the weapons into separate modules. This will be a problem because all items are unknown. But that would be the best way. If you insist on server compatibility, we can only remove the API from the weapons for a separate module. But in this case she will not be called a shooter (which would be ideal, in my opinion)

stujones11 commented 7 years ago

We can maintain backwards compatibility with items by including aliases that can eventually be removed from future versions. Just keep your changes small and submit them to a feature branch or make PR for review. I am mostly AFK weekdays but may be able to occasionally review small changes from my mobile.

I would prefer any server breakage to wait until minetest 0.5.0 then we can break what we want ;-)

BrunoMine commented 7 years ago

I started separating the rocket 132636d. Make sure you agree.

stujones11 commented 6 years ago

Your PR has now been merged to the new development branch: https://github.com/stujones11/shooter/tree/0.6.0-dev

Thank you for your patience, this issue can remain open for now.

BrunoMine commented 6 years ago

Should this be kept open? Because?

stujones11 commented 5 years ago

Should this be kept open? Because?

Because it is still in development :) I will close this issue when I merge the 0.6.0-dev into master, it is a part of the milestone.

Edit: To be fair, this part is technically complete only it lacks a few extras, like individual mod screenshots, meta files, etc.

stujones11 commented 5 years ago

Version 0.6.0-dev has now been merged into master, I will likely make an 'official' release sometime tomorrow. Any testing in the meantime would be greatly appreciated.