search

stujones11 / shooter

First Person Shooter Mod for Minetest
Other
30 stars 18 forks source link

Update crossbow.lua #24

Closed doyousketch2 closed 5 years ago

doyousketch2 commented 6 years ago

shooter_"..name..".png was in there twice

HybridDog commented 6 years ago

This may be used to ensure that the result texture has the resolution of the shooter_"..name..".png texture. However, recently there were changes in minetest source code. You could test it with and without the change with e.g. 64x64 wool textures.

doyousketch2 commented 6 years ago

Oh yeah yeah, I remember having to do that in an old buggy turret mod. Forgot it was about the texture size. Wonder if it's still needed. Didn't seem to have an effect either way here, that's why I submitted it... but was going on default texture size, so I wouldn't-a seen a difference. I'll try it out later on & see. Maybe just a comment then, so readers know why the code's that way.

HybridDog commented 6 years ago

https://github.com/minetest/minetest/commit/31c1fca6fd5e200c4f4b24d7ba62b36a16494ed2#diff-8b1361a90a460ea33ecf3db026997f8a l guess it's scaled automatically now, so you're right with the PR.

https://github.com/stujones11/shooter/commit/dc86ef4ecba68033cdcf35388e9058d86a2bc031 l wrote the code before the change.

stujones11 commented 6 years ago

Thanks for the PR, it seems reasonable enough but I am not sure if the auto-scaling feature is present in the current minimum supported MT version 0.4.9. This would, however, be quite welcome in the new 0.6.0-dev branch, though I could possibly redirect your commit there myself if necessary.

stujones11 commented 5 years ago

Merged into 0.6.0-dev 9bf3ce60f22ab7c14b72ed1515c2d9ac68217ddd