search

stujones11 / shooter

First Person Shooter Mod for Minetest
Other
30 stars 18 forks source link

Recipe broken for machine gun. #42

Closed ghost closed 5 years ago

ghost commented 5 years ago

https://github.com/stujones11/shooter/blob/63ca8472aee5feae1c428b406ecb3dce5c7b6a66/shooter_guns/init.lua#L139

Line 139 of init.lua should be changed from {"shooter_guns:steel_ingot", "default:steel_ingot", "default:steel_ingot"}, to {"default:steel_ingot", "default:steel_ingot", "default:steel_ingot"},

This concerns the crafting recipe for the machine gun. I noticed this when adding this to my server and reviewing the item in the crafting menu. I've made the proposed change mentioned in my own server and it resolved this.

I'm new to git so I don't know how to create and submit this myself. Would this be a pull request?

LoneWolfHT commented 5 years ago

Open the file you need to edit and click the pencil button. Should be obvious from there onwards image

For more complex edits you will need to learn how to use the git command line (Or at least use VSCode). But this is simple enough to just do via Github

ghost commented 5 years ago

Thanks, I believe I've successfully submitted the pull request for this.

LoneWolfHT commented 5 years ago

Thanks, I believe I've successfully submitted the pull request for this.

I don't see any PR. And your fork is even with the master branch https://github.com/jeremyweston/shooter Edit your fork's file then press the button highlighted green in the pic. If your changes were saved to your fork you should be able to create a PR to this repo image

ghost commented 5 years ago

OK, thanks, I've submitted the PR. Thanks for the help, I'm new to this.

stujones11 commented 5 years ago

Thanks guys, fixed by 8caadbab5e2d04771c10b022ac1da2e5bea89766