Merge from CTF/shooter - Githubissues

stujones11 / shooter

First Person Shooter Mod for Minetest

Other

30 stars 18 forks source link

Merge from CTF/shooter #48

Closed rubenwardy closed 4 years ago

rubenwardy commented 4 years ago

This PR contains all fixes in CTF's fork of shooter. We've tried to keep the changes limited to things that upstream shooter may want to have. For all our changes, also look at the shooter_tweaks mod.

You may not want to merge this all, but instead review and cherry-pick fixes. I'm also happy to make PRs for each fix if that would help you

Re "Fix shooter.get_weapon_spec": I made a mistake when backporting get_weapon_spec to shooter originally. Here's the fix

rubenwardy commented 4 years ago

This fix multiple things because I accidentally made it from master, I should split into multiple PRs

ClobberXD commented 4 years ago

This PR now includes a fix for #51

ClobberXD commented 4 years ago

There's no open issue that corresponds to https://github.com/stujones11/shooter/pull/48/commits/3d7ad1a6bc2a187366759fe1895a9afc1efc7641, but the commit passes the player object to punch instead of the arrow object - bc technically, it's the player "punching" the target, and not the arrow itself.

LoneWolfHT commented 4 years ago

https://github.com/stujones11/shooter/pull/48/commits/d7f6dc7c06110ca7f1eead0b15b6630d7466c649 isn't exactly a bugfix, I can remove if wanted