search

stumpapp / stump

A free and open source comics, manga and digital book server with OPDS support (WIP)
https://stumpapp.dev
MIT License
941 stars 43 forks source link

[FEATURE] Scanner ignore rules #284

Closed aaronleopold closed 3 weeks ago

aaronleopold commented 7 months ago

Is your feature request related to a problem? Please describe.

This supersedes #53

I don't feel that managing opt-in ignore rules via .stumpignore files is the best route to take. One so people don't have a slightly tedious chore if they decide to uninstall Stump, but mostly it just isn't a great management flow IMO.

Describe the solution you'd like

Support dumping a set of ignore rules to the DB instead, this can be populated via the UI

Additional context

I am unsure if series should have their own ignore rules, and regardless of whether they do if they should inherit the rules from the library. I think, in general, the 'rules' of these rule-sets needs to be thought through and defined a bit.

mr-szgz commented 2 months ago

Have you considered a simple ignore list of RegEx strings? or globs? I personally find globs, especially with autocomplete, is quite user-friendly.

For regex, here is an example from another media app I use: IMG_0309

aaronleopold commented 2 months ago

Hey! 👋 what you described is already planned. Previously, Stump supported .stumpignore files which contained a set of glob strings. This issue aims to replace that with a persisted value in the DB, which can be viewed/managed on the UI

Edit to express I totally misread your actual question 😅 I updated my response, but for clarity the plan is to use globs not regex

aaronleopold commented 3 weeks ago

Implemented as of https://github.com/stumpapp/stump/pull/422, tentatively to be released in 0.0.7