stumpapp / stump

A free and open source comics, manga and digital book server with OPDS support (WIP)
https://stumpapp.dev
MIT License
938 stars 43 forks source link

[BUG] Full screen is not working on the reader #355

Open jayjoshi64 opened 3 months ago

jayjoshi64 commented 3 months ago

Describe the bug Clicking on full screen icon does nothing.

To Reproduce

  1. Open any ebooks (I am using .epub book)
  2. Click on the full screen.
  3. ...Nothing happens

Expected behavior The reader view should be full screened

Screenshots Jun-26-2024 12-54-03

Desktop (please complete the following information):

aaronleopold commented 3 months ago

This isn't actually a bug, just perhaps misleading and/or bad UX.

The header and footer UI components are fixed and constantly visible. When you enter "full screen" mode they instead hide after a second or two of losing focus / mouse exit.

It does not control your browser's full screen functionality.

jayjoshi64 commented 3 months ago

I see. Let's make it a little obvious if possible.

jayjoshi64 commented 3 months ago

Although, it's not the most important thing probably. I'll see if I can raise a PR in few weeks. I'll also check if I can directly add the functionality to support browser full screen.

aaronleopold commented 3 months ago

Yeah for sure, I'm down to play with the UI to improve the overall experience. I won't have time in the immediate few weeks, as I am focusing on a few other features already, but can make some time afterwards.

I'll see if I can raise a PR in few weeks.

If you need anything please reach out! There is a dedicated dev channel on the Discord, as well.