search

stur86 / crystvis-js

A Three.js based crystallographic visualisation tool
https://stur86.github.io/crystvis-js/
MIT License
15 stars 7 forks source link

Breaking changes to BoxGeometry in three 0.125+ #16

Closed elichad closed 3 years ago

elichad commented 3 years ago

Release Three 0.125 changed the BoxGeometry class so it no longer has a vertices attribute - this affects the BoxMesh class here. There might be other breaking changes too.

The line linked above is breaking when I try to load a file into the renderer through Galaxy (reverting to three 0.124 fixes it). This doesn't seem to break the demo or tests, though, which is odd as they also call BoxMesh.

stur86 commented 3 years ago

Thanks, I'll take a look at this!

elichad commented 3 years ago

The tests do actually fail with 0.125, I had some caching happening without realising. Demo still seems to work though.

stur86 commented 3 years ago

Fixed in https://github.com/stur86/crystvis-js/commit/74556f9c288645d9a2d620c784f2a686217c944c.