Closed nickveenhof closed 1 year ago
Looks good. I kind of wanted to keep the permissions as narrow as possible though. Maybe there's a better way of solving this? For the host_permissions
I was thinking we could use this optional_host_permissions
Are like regular host_permissions, but are granted by the extension's user at runtime, rather than in advance.
https://developer.chrome.com/docs/extensions/mv3/declare_permissions/
(for a nicer UX we could pick a the host from the URL and ask for confirmation)
The scripting part, I guess there might not be a better way of doing this
Looks good. I kind of wanted to keep the permissions as narrow as possible though. Maybe there's a better way of solving this? For the
host_permissions
I was thinking we could use thisoptional_host_permissions
Agree. Let's change it so that github.com & gitlab.com are added by default, and the rest as optional.
Updated the permissions. Validated it still works as expected
The scripting part, I guess there might not be a better way of doing this
Probably there is a cleaner way to order the code, but that would make is less readable. I am not the best javascript programmer, so hopefully someone in the community can help us clean this code. 🤞
Fixes #15