search

sturobson / Sassifaction

A Sass mixin library
The Unlicense
178 stars 13 forks source link

Incorrect RGBa fallbacks #16

Open ogbaoghene opened 10 years ago

ogbaoghene commented 10 years ago

The color generated by the function for RGBa fallbacks is actually of a very different shade/ tint of the transparent original.

sturobson commented 10 years ago

Have you got a codepen or something to give more detail?

ogbaoghene commented 10 years ago

Yea, sure. Forked the original, I understand the fallback is only an approximation and it work okay with some colors. But the fallback for light grays is too light and it just gets wonky with some colors.

sturobson commented 10 years ago

Perhaps I'll rip it out and replace it with this - http://codepen.io/BPScott/pen/wpBiI, thoughts?

ogbaoghene commented 10 years ago

Seems like a great option to explore, it's much more flexible too, taking into consideration other background colors apart from black and white. This also uses that approach - http://codepen.io/FernE97/pen/qcHlr, but it uses mix instead of RGB Functions.

ogbaoghene commented 10 years ago

Came up with this: RGBa Fallback http://codepen.io/Tenesan/pen/gcwqh