sturobson / Sassifaction

A Sass mixin library
The Unlicense
178 stars 13 forks source link

Fixing unit issue in _shapes.scss #9

Closed KittyGiraudel closed 10 years ago

KittyGiraudel commented 10 years ago

Setting default value for $size argument of circle(), square() and rectangle() to an empty string ("") can lead to various issues since it makes the width a string instead of a number.

I suggest you set the default value to 0 instead to avoid any data type issue.

More on topic: http://hugogiraudel.com/2013/09/03/use-lengths-not-strings/.