search

stutrek / scrollmonitor

A simple and fast API to monitor elements as you scroll
MIT License
3.3k stars 243 forks source link

Fixed case in the readme's require reference. #31

Closed igregson closed 6 years ago

igregson commented 9 years ago

After trying to get this wired up with a basic Browserify setup I wanted to correct this in order to potentially save others some time.

I thought that the module might require all lowercase, but for the longest time simply relied on the readme and didn't test. Eventually I tested. This PR's a simple attempt to save others some time.

Thanks for the great looking package!

stutrek commented 9 years ago

This is a hard one because requirejs needs the capitals. I made this before browserify and bower were big. If I had to do it again I would have named the file scrollmonitor.js without the camel case. However, I'm not going to make a major version change to do that.

I honestly don't know what the best thing to do here is. If people +1 it I'll merge.

stutrek commented 6 years ago

I changed it on the readme. It's 2018, the change was long overdue.