Database column not removed on deactivating

stuttter / wp-term-order

Sort taxonomy terms, your way

https://wordpress.org/plugins/wp-term-order/

GNU General Public License v2.0

95 stars 24 forks source link

Database column not removed on deactivating #9

Open ians88 opened 8 years ago

ians88 commented 8 years ago

I noticed that the row 'order' is not removed when deactivating the plugin. Isn't this desirable behavior, since now you 'polute' the database after checking a plugin out, or removing it once it is not needed anymore. Could a register_deactivation_hook be used? If so I'd be happy to do some code for it and make a pull request, but thought I'd ask first why this isn't implemented yet.

lmoffereins commented 7 years ago

I think the column should only be removed when uninstalling the plugin. I'd rather not lose data when I just deactivated this plugin - be it by accident or on purpose.