search

stuyam / pressure

:point_down::boom: JavaScript library for handling Force Touch, 3D Touch, and Pointer Pressure.
https://pressurejs.com
MIT License
2.92k stars 97 forks source link

fix: use gulp-umd instead of buggy globalize #52

Closed zetlen closed 8 years ago

zetlen commented 8 years ago

The globalize.js file used to export to various module loader environments had some buggy behavior in it, making it incompatible with Webpack in next.js. This replaces the hardcoded globalize.js and IIFE wrapper with the standardized UMD wrapper, provided by the gulp-umd plugin.

There is no change in functionality, except that for isomorphic apps, Pressure.js will load, but all its methods will be no-ops.

stuyam commented 8 years ago

@zetlen wow this is awesome 🙌! Really great stuff in here, that UMD package is definitely a big improvement and makes the compilation less fragile so thank you for that! I will update this later tonight!

Thanks so much again!

stuyam commented 8 years ago

@zetlen just deployed this as v2.0.2, thanks for the contribution! Greatly appreciated. https://github.com/stuyam/pressure/releases/tag/v2.0.2

zetlen commented 8 years ago

Hey, I'm sorry it took me a while to respond to this--work has been hectic. Sorry I forgot to remote the old dep, that was sloppy of me. I see you've taken care of it.

Hey, your library is great. I really appreciate you doing the work to normalize this into a clean API. You can see it in action, in my own little way, on my personal website: https://zetlen.github.io

stuyam commented 8 years ago

@zetlen that is awesome to hear, love the site, very clever! Again I appreciate the help with that last PR, big help.

Quick question, would you mind taking a look at this issue, I know that pressure works, but I am not sure why this is the case: https://github.com/stuyam/pressure/issues/53