search

stuycs-softdev-fall-2013 / proj3-7-bookmarx

Bookmarks for the people
2 stars 0 forks source link

Write user functions #3

Closed zanesterling closed 10 years ago

zanesterling commented 10 years ago

I need two functions: authUser and addUser. authUser takes a user's id (a string of digits prefaced by a letter) and returns "returning-user" if the user has already registered, and "new-user" if the user has not registered before. addUser takes the id and username of a user to be registered and adds them to the database. It should also set up whatever defaults a new user is supposed to have.

cburke496 commented 10 years ago

I thought users didn't have ids, they're just identified by username.

zanesterling commented 10 years ago

I think our official name for it is an OAuth Token. Google and Facebook refer to it as an id, so that's what I was thinking of at the time.

Hypersonic commented 10 years ago

OAuth tokens probably aren't unique if we're getting them from multiple sites (Google, Facebook). It should be unique to the site, but if we have two users who register though Google and Facebook respectively, and are assigned the token with the same value, we're gonna have a bad time.

zanesterling commented 10 years ago

This is why I appended the letter to the start. So a Google OAuth token looks like g12524376542375 and a facebook token looks like f125143626.

On Sun, Jan 12, 2014 at 9:51 PM, Josh Hofing notifications@github.comwrote:

OAuth tokens probably aren't unique if we're getting them from multiple sites (Google, Facebook). It should be unique to the site, but if we have two users who register though Google and Facebook respectively, and are assigned the token with the same value, we're gonna have a bad time.

— Reply to this email directly or view it on GitHubhttps://github.com/stuycs-softdev/proj3-7-bookmarx/issues/3#issuecomment-32142659 .

zanesterling commented 10 years ago

This was the wrong way to do things, good thing we didn't.