search

stuyspec / stuyspec-rewrite

The rewrite of The Stuyvesant Spectator's website!
https://beta.stuyspec.com
GNU General Public License v3.0
7 stars 33 forks source link

Change Preview Image Opening #41

Closed exu160 closed 1 year ago

exu160 commented 1 year ago

Changed PreviewImage.tsx so that when you click on the preview image, it opens the link on a new page instead of opening it on the current page.

leomet07 commented 1 year ago

Hi @exu160 !

Thank you for your contribution! I don't have any major edits to request from you :)

Read up the commit that I added! It's a good practice for when you use target="_blank" and addresses this security bug (https://mathiasbynens.github.io/rel-noopener/)!

Check out your contributions on stuyspec.com, they're already live!

Make sure to rebase and maintain your fork now! (See the "Next Steps" section at the end of the instructions sent out!)