search

stuysu / epsilon

all in one service for stuyvesant high school.
8 stars 0 forks source link

Dark mode light mode toggle icon shifts when changing between some pages #130

Closed randysim closed 3 days ago

randysim commented 3 days ago

This probably means the whole navbar is changing too, looks weird

SnowyNate commented 3 days ago

For additional information, I've noticed this only occurs when there is a scroll bar. This may be fixed by implementing a custom scroll bar, which would add to the UI enhancements in the future. However, there isn't any easy way to do this apparently. Another idea I have is to move the default position of the icon so that it is away from the scrollbar, but I'm unsure if the scrollbar shifts the ENTIRE page or just the icon.

SnowyNate commented 3 days ago

Found a solution. Will attempt to implement this.

SnowyNate commented 3 days ago

The scrollbar lacks visibility when dark mode is applied. I will try to fix this.

SnowyNate commented 3 days ago

Fixed by PR #133 .