randysim
commented
1 week ago Really good first issue, so gonna leave this for newcomers (unless I get to it first)
- Step 1: Go to supabase database dashboard, go to the triggerse tab, and remove the create_creator_membership trigger, a trigger is just SQL code that gets run after something happens
- Step 2: update this github to remove that trigger. It's probably in ORG POLICY or ORGANIZATION sql files. Also remove the creator_id field and reflect changes in production as well as the github.
- Step 3: go to github.com/stuysu/epsilon-functions and go to the create-organization route. Remove the need for a creator_id and just let the supabaseAdminClient create a creator membership for the user.
- Step 4: make sure all changes are reflected in github and production
This is just a code re-factoring request, the other solution works fine but is definitely hard to understand/scuffed for someone trying to hop onto the project.
Initially, I made it so that an organization has a creator_id field. When it is created, it triggers an SQL database function that creates the membership. But now we added edge functions so it would probably make more sense to do it all in the edge function and get rid of a redundant field that will be hard to keep track of.