Week 6 Assignment - Feedback

[albertbahia]

Nice job with the homework.

Things to note:

• One suggestion would be to open a new tab when you click on your commit links. That way the user can keep the current tab while also having the ability to view the other tab as well.
• For your commits, a possible reason for your Author value not coming up is that you needed to go another level deeper the name key/property. (https://github.com/stvbuller/Portfolio_SB/blob/master/jscripts/getCommits.js#L21):

 var authorTd = $("<td>").append(commitData.author.name);

[stvbuller]

Thanks!

On Dec 10, 2015, at 11:21 PM, Albert Bahia notifications@github.com wrote:

Nice job with the homework.

Things to note:

One suggestion would be to open a new tab when you click on your commit links. That way the user can keep the current tab while also having the ability to view the other tab as well. For your commits, a possible reason for your Author value not coming up is that you needed to go another level deeper the name key/property. (https://github.com/stvbuller/Portfolio_SB/blob/master/jscripts/getCommits.js#L21 https://github.com/stvbuller/Portfolio_SB/blob/master/jscripts/getCommits.js#L21): var authorTd = $("").append(commitData.author.name); — Reply to this email directly or view it on GitHub https://github.com/stvbuller/Portfolio_SB/issues/4.