search

stvhwrd / GitHunt-Dark

:octocat: :chart_with_upwards_trend: [Chrome extension] - Replace your new tab page with trending GitHub repositories
https://chrome.google.com/webstore/detail/githunt-dark/eaholbmncablicmnmlpngnhhgpkfcjfa
MIT License
7 stars 1 forks source link

Support Github's emoji colon syntax, eg. :smile: #8

Open alirezaomidi opened 7 years ago

alirezaomidi commented 7 years ago

This version shows emojis like :octocat: and :electric_plug: instead of :octocat: and :electric_plug: .

This should be fixed.

alirezaomidi commented 6 years ago

anyone?! @stvhwrd

stvhwrd commented 6 years ago

Hi @alirezaomidi, sorry for the delay. This issue got buried in my notifications.

The emoji you specifically referred to are not part of unicode, but are actually from Github's own emoji set... But your point still stands. Even standard emoji currently can't be called using the colon syntax like :smile: for 😄.

This could probably be wholly remedied using gh-emoji for example. You're welcome to (and I encourage you to) fork and play around with it, and I'd be happy to receive a pull request from you - otherwise I'll have to get to this after exams, which conclude in a few weeks.

TL;DR: You're right. I'm wrong. You can fix it, or I will, in a few weeks.

Thanks for opening the issue!

stvhwrd commented 6 years ago

On second thought, gh-emoji might be overkill for GitHunt-Dark's needs.

Instead, GitHub has a very straightforward emoji JSON API that could be used.