stvhwrd / Stock-Trading-System-HTTP-Server

📈💱 [Containerized Go server] HTTP Server for Stock Trading System project
1 stars 0 forks source link

Enable Logging #15

Closed stvhwrd closed 5 years ago

stvhwrd commented 5 years ago

HTTP Server will contribute four logs:

DebugType

Debugging messages contain all the information of user commands, in addition to an optional debug message

ErrorEventType

Error messages contain all the information of user commands, in addition to an optional error message

SystemEventType

System events can be current user commands, interserver communications, or the execution of previously set triggers

UserCommandType

User commands come from the user command files or from manual entries in UI web forms

stvhwrd commented 5 years ago

Since every log is tied to a transaction number and a command, should probably maintain one ~global~ appropriately scoped commonlib.LogCommandParameters instance per request

qqqstuv commented 5 years ago

Sorry I'm a bit unsured why should we keep track of LogCommandParameters per request? Isn't the webserver done with LogCommandParameters after it has sent off a message to logging server? Also afaik the workload generator currently does not send the transactionNumber to webserver. I need to enable that at some point, right?

stvhwrd commented 5 years ago

No need to enable that - the HTTP server now assigns transactionNum as the requests come in. We'll need to modify the parameters downstream to ensure that transactionNum propagates