stvmallen / homebridge-roomba-stv

Homebrige plugin for Roomba 9xx
MIT License
38 stars 15 forks source link

Hangs when invalid hostname is supplied #56

Open timothybasanov opened 4 years ago

timothybasanov commented 4 years ago

Expected Behavior

Invalid hostname or IP address should fail promptly and mark only Roomba accessory as unavailable.

Current Behavior

When I supply bogus hostname e.g. foobar homebridge hangs in “updating” status. No error are logged to the console even when debug logging is enabled.

Versions

Configuration

`"keepAliveEnabled": true

Homebridge Log / Command Output

Running status requested
Battery status requested

Notes: Why is it important? My Roomba got stuck for a few days. At some point DHCP lease expired and roomba’s hostname no longer could be resolved. This unexpectedly caused the whole Homebridge to become unresponsive.

solbadguy2010 commented 4 years ago

You are not alone.

https://github.com/esteban-mallen/homebridge-roomba-stv/issues/36