search

stvmallen / homebridge-roomba-stv

Homebrige plugin for Roomba 9xx
MIT License
38 stars 15 forks source link

Roomba failed connection causes other Homebridge accessories to be unresponsive #58

Open JazzerAlto opened 4 years ago

JazzerAlto commented 4 years ago

Expected Behavior

If Homebridge cannot connect to the Roomba, other accessories will not be impacted

Current Behavior

When the plugin fails to connect to Roomba, or it just takes too long to get the response, other accessories will also become unresponsive

Steps to Reproduce (for bugs)

Let your Roomba battery die

Versions

Can you use this code to insert a timeout function so this plugin doesn't hold other plug ins hostage?

https://github.com/stevenliuyi/homebridge-irobot-roomba690

chrispi68 commented 4 years ago

Same problem here. I had to remove this plugin and now everything works again.

i3laze commented 4 years ago

+1, whole HB becomes unresponsive periodically with auto-refresh enabled. We need a rewrite of this feature, like query timeout 2 secs something.

scottbell commented 4 years ago

This would be great to fix!

ncovercash commented 4 years ago

I'd recommend, for the meantime at least, creating a few homebridge instances for your various plugins – this also helps any looping or frozen plugins from taking over everything!

i3laze commented 4 years ago

I'd recommend, for the meantime at least, creating a few homebridge instances for your various plugins – this also helps any looping or frozen plugins from taking over everything!

Sounds reasonable, although recently a HomeBridge is taking leaps in update cycle and hopefully will improve its polling and freezing stuff someday.

whreams commented 4 years ago

I'm getting this also. I'm into day 2 of my test which consists of not using this plugin and monitoring the "no response" call of other HB plugins. Will check back in if after another couple of days I show stability. I'd rather not run another instance of HB just to support this plugin - but do like it very much as it also seems to support my s9 Roomba.

tideline3d commented 4 years ago

Just ran into this problem, Roomba was stuck under a chair and battery died, causing all my HB switches to be non responsive. Putting Roomba back on the charger fixed it immediately.

Pblondin123 commented 4 years ago

see issue 66 - i removed autorefresh and keepalive and it stabilized the plugin. On/Off only for now, but it fullfills my main requirement which is to start when everybody's out the house, and goes back home when first person comes back.

whreams commented 4 years ago

I also confirm s9 functionality.

On Aug 22, 2020, at 8:36 AM, Pblondin123 notifications@github.com wrote:

see issue 66 - i removed autorefresh and keepalive and it stabilized the plugin. On/Off only for now, but it fullfills my main requirement which is to start when everybody's out the house, and goes back home when first person comes back.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stvmallen/homebridge-roomba-stv/issues/58#issuecomment-678642218, or unsubscribe https://github.com/notifications/unsubscribe-auth/APK2HVXNVV73XQQW4JFE6TDSB7CXFANCNFSM4M4G7OUA.