search

stwe / DatatablesBundle

This Bundle integrates the jQuery DataTables plugin into your Symfony application.
355 stars 236 forks source link

Update DatatableQueryBuilder.php to fix #936 (null value in setSelectSearchType) #939

Closed knallcharge closed 4 years ago

knallcharge commented 4 years ago

it's possible for a null value to sneak through "addAndExpression", fixes #936

Seb33300 commented 4 years ago

I think this should be fixed here: https://github.com/stwe/DatatablesBundle/blob/master/Response/DatatableQueryBuilder.php#L534

knallcharge commented 4 years ago

fine with me :)

Seb33300 commented 4 years ago

I think 'null' !== $searchValue was a mistake. I think you can remove it.

We should be able to search for 'null' string.

knallcharge commented 4 years ago

done