Fix memory access crash

stweil / OSXvnc

VNC Server for macOS

GNU General Public License v3.0

208 stars 69 forks source link

Closed mykola-mokhnach closed 3 years ago

mykola-mokhnach commented 5 years ago

In general dealloc should never be called explicitly.

stweil commented 5 years ago

We don't use automatic garbage collection. How will the object be removed with neither dealloc nor release being called?

mykola-mokhnach commented 5 years ago

There is the autorelease pool. Having dealloc there makes the object to be deallocated twice

stweil commented 3 years ago

@aleksosim reported that this pull request fixes issue #48, so I merged it now. I am sorry that this took so long.

Thank you for the fix.