search

stwlam / adequate-vision

A serviceable darkvision mode for Foundry VTT's dnd5e system
MIT License
2 stars 4 forks source link

Add missing range test to the See Invisibility detection mode #15

Closed dev7355608 closed 2 years ago

stwlam commented 2 years ago

Is there a reason to not use the los cache for See Invisibility?

dev7355608 commented 2 years ago

See Invisibility isn't constrained by walls. It just removes the invisibility condition and then test if another detection mode would see the target; so this other detection mode might ignore walls and therefore reveal an invisible token behind a wall (x-ray vision that can't see invisible creatures). I set the walls property to false reflect that. We could add the _testLOS check in there, but it wouldn't have any effect if walls is false.