search

styanddty / blockly

Automatically exported from code.google.com/p/blockly
0 stars 0 forks source link

FieldDropdown needs class to attach to top component rather than using global class members #115

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
While looking at Bug 113, I noticed that some of FieldDropdown is for an object 
and some is for a single object that goes with the workspace and is reused.

This would be better if it were refactored into two classes - a 
FieldDropdownGroup that is a subcomponent of the top component (SvgComponent) 
and this existing class that should remain for objects.

Rather than having hideChaff know about all of the possible global class 
members to call hide on, a hide event should be dispatched, possibly on the top 
SvgComponent that objects like the FieldDropdownGroup can add listeners to when 
enterDocument is called, the intended place for goog.ui.Components to do so.

Original issue reported on code.google.com by s...@google.com on 9 Feb 2013 at 7:52

GoogleCodeExporter commented 8 years ago 
Ultimately the SVG dropdown needs to be replaced with an identically-styled 
Closure widget.  This would live in HTML-land (just like the colour picker and 
the new toolbox).

Advantages:
* Cursor key access to menu options.
* Fixes issue 64 of off-screen dorpdowns.

Original comment by neil.fra...@gmail.com on 9 Feb 2013 at 8:11

GoogleCodeExporter commented 8 years ago 
This refactoring has been moved to the experimental branch.  It is no longer 
blocking trunk.

Original comment by neil.fra...@gmail.com on 11 Mar 2013 at 11:06