Closed Mile-Lile closed 2 years ago
Hello, and thanks for reaching out. =)
First make sure @BrainSlayer knows how appreciated that offer is. Its great to get some recognition.
This style compiles to down to CSS, anyone could grab the resulting CSS and do that (this is MIT license). However its not as simple as just converting it and adding another CSS file or five.
To truly have a 1:1 official DD-WRT would have include the custom checkboxes/inputs/icons modernized redesigns of icons e.g. I use SVG icons, DD-WRT uses old gifs. Logos and any graphics all need to be redone, so you dont see the white edges when over specific dark background colors, the most obvious are the hotspot logos.
DD-WRT uses a oversimplified number of CSS classes, I had to pick at other inline portion to be able to target specific portions in order to be able to distinguish between certain elements like e.g. this [name='add_button']:not([onclick*='_add'])
a long dance is done all over this project to make this style possible.
As well as the above, any user customizable options would be 100% lost in any process of including any 1 single color schemes as a simple CSS theme.
The current approach that DD-WRT uses for dark themes would need a considerable overall in order to be anywhere ready for actually to get something that looks like this as a end result and is as comprehensive and detailed thoughout all areas. (the details are important to me).
TL;DR
I wouldn't mind the challenge of improving the built in themes add new ones, extend classes add modern graphics and dig though source code to make it happen, some collaboration/dialog with @BrainSlayer and perhaps other people involved with DD-WRT like @egc112, Work like this would take many many hours maybe even months who knows how long this piece of string really is (since this is done on spare time for me). Some real time dialog would probably be needed at some stage.
SVN is a big obstacle for resolving any arising conflicts between edited files and actual live changes (if any) and seeing on the fly any submitted changes spotting any issues visually before they are committed, this would slow down further this work considerably in my experience.
Other words (sorry for rambling)
Why I did this style as is, 3 months of ON/OFF development and ready for consumption, Some small way to give back to the community and BS for the tireless work he does on DDWRT. Kudos.
I hope though anyone that stumbles on this style, doesn't mind installing Stylus and this style to enjoy the work in the meanwhile like detailed in the readme https://github.com/style-it-themes/dd-wrt-inspired-themes#installing
And thanks again for reaching out.
Hello, and thanks for reaching out. =)
First make sure @BrainSlayer knows how appreciated that offer is. Its great to get some recognition.
i'm BrainSlayer :-)
This style compiles to down to CSS, anyone could grab the resulting CSS and do that. However its not as simple as just converting it and adding another CSS file or five.
i know. but if i at least have a possibility to generate the css, i can make all adjustments manually. but i'm not experienced with css that much. most of the styles are contributions.
To truly have a 1:1 official DD-WRT would have include the custom checkboxes/inputs/icons modernized redesigns of icons e.g. I use SVG icons, DD-WRT uses old gifs . Logos and any graphics all need to be redone, so you dont see the white edges when over specific dark background colors, the most obvious are the hotspot logos.
i do not use gif. i use png. but doesnt make a difference. not scalable
DD-WRT uses a oversimplified number of CSS classes, I had to pick at other inline portion to be able to target specific portions in order to be able to distinguish between certain elements like e.g. this [name='add_button']:not([onclick*='_add']) a long dance is done all over this project to make this style possible.
As well as the above, any user customizable options would be 100% lost in any process of including any 1 single color schemes as a simple CSS theme.
The current approach that DD-WRT uses for dark themes would need a considerable overall in order to be anywhere ready for actually to get something that looks like this as a end result and is as comprehensive and detailed thoughout all areas. (the details are important to me).
the dark style is basicly a additional css style which is placed into the header once its activated. all done by the C cgi web code.
TL;DR
I wouldn't mind the challenge of improving the built in themes add new ones, extend classes add modern graphics and dig though source code to make it happen, some collaboration/dialog with BrainSlayer and perhaps other people involved with DD-WRT like @egc112, Work like this would take many many hours maybe even months who knows how long this piece of string really is (since this is done on spare time for me). Some real time dialog would probably be needed at some stage. i'm available almost all day by email, but in worst case also with phone or skype, whatsapp. whatever. timezone needs to be considered of course since i'm located in germany
SVN is a big obstacle for resolving any arising conflicts between edited files and actual live changes (if any) and seeing on the fly any submitted changes spotting any issues visually before they are committed, this would slow down further this work considerably in my experience.
there are some hidden features in dd-wrt. if you place a new file in the file system at / it will be used if its a new file which is not defined by the normal webfile set. this can be used for adding new unknown styles.
so create /style/mystyle/style.css in the filesystem then create a folder /www/style/mystyle (just the folder)
then your new style shows up on the selection and can be tested
i did not test this for long time of course :-) the read from the root path is also a bug. normally it should be /www of course. i will fix this usually in next release. so you can do it directly also in a better way since the fs is readonly you need to extract and replace it of course. but there is a dirty trick
mkdir /tmp/mywww mount --bind /tmp/mywww /www
so you can use scp and upload it to the tmp/mywww folder
Other words (sorry for rambling)
Why I did this style as is, 3 months of ON/OFF development and ready for consumption, Some small way to give back to the community and BS for the tireless work he does on DDWRT. Kudos. i like if people talk to my as third person :-)
I hope though anyone that stumbles on this style, doesn't mind installing Stylus and this style to enjoy the work in the meanwhile like detailed in the readme https://github.com/style-it-themes/dd-wrt-inspired-themes#installing
And thanks again for reaching out.
i'm BrainSlayer :-)
Indeed =) thanks for all your work on DD_WRT
i know. but if i at least have a possibility to generate the css, i can make all adjustments manually. but i'm not experienced with css that much. most of the styles are contributions.
This is semi easy... Assuming you have Stylus and this style installed.
Im sure you know this but here it is.
Open the browser inspector Im using Firefox mostly so its ctrl+shiif+i
and choose the Style editor tab
Navigating around the files on my end the main compiled CSS it shows up as <inline style sheet #5>, this may vary but the main has 237 rules (see gif)
The name could vary but you get the idea, I hope.
For other sections other inline style sheets are used like e.g oid search, speedchecker and so on. these are equally as important as main style, so as to ensure consistency throughout.
Here is a gist of that compiled CSS (as the animation shows) https://gist.github.com/the-j0k3r/26e7b9d974c12231f234f3bac44ce085 for example =)
But just as is, you may actually get a single color style and you lost all custom stuff and despite all svgs being optimized and being as small as possible, the overall result may increase slighly the overall size because Im inlining all SVG code and base64 encode replaced pngs
the dark style is basicly a additional css style which is placed into the header once its activated. all done by the C cgi web code.
Above my head slightly cgi/C but I think I get some idea.
i do not use gif. i use png. but doesnt make a difference. not scalable
I see many gifs dotted around =), indeed mostly I replaced pngs e.g. ddwrt.css has many for instance, I think default.css also shows some. I do prefer svgs mostly because scalability and easy to recolor in styles/projects like this.
Some of those gifs are just inverted with css filters and hacks to pngs etc use other CSS trickery.
Graphic design, CSS, HTML and what not is not problem, One of the may technologies I work with in RL.
If you havent already installed Stylus and this style, I recommend you do and do play around with the custom options colors and bilt ins styles, each color scheme results in same :root color values changes, which makes a new color scheme. Possibilities many.
And so on.
Also note that margin padding and other such tweaks are new or override the default blue style values or the default CSS that has them,
Some values are added and some override existing in these properties types. as a standalone CSS the end result may need adjusting depending on whats going on.
In addition dd-wrt has many inline color properties which makes any built in themes that have CSS files harder to override e.g.
Such inline colors should be replaced by some new css class, so that any existing themes/new themes can properly style all areas for consistency sake, even if they can be overridden like Ive done in such cases, its really a bane of styling with CSS alone, dd-wrt isnt alone in this, many more modern websites use them still. the more ppl work on same website the worst it becomes.
This is why built in styles dont actually style consistently and one of the main drivers for this project.
I recommend some care is payed in the examples given, for best results that is.
i found some bugs. if i enable the stylus. i cannot click on the status tab anymore
i found some bugs. if i enable the stylus. i cannot click on the status tab anymore
@BrainSlayer thanks for that report however;
This style doesn't affect such things or even attempt to alter such functionality. And Stylus even less. So its a little weird
Tested it on Edge chromium 93.0.961.38 (Official build) (64-bit) Firefox 91.0.2 (64-bit) OS: Windows 10 pro 2004
What browser are you using and browser version? Stylus version?
Operative system? Just in case so I can test similar setup.
Also ensure you're not using the CSS file I provided above and you followed the install instructions https://github.com/style-it-themes/dd-wrt-inspired-themes#installing
Proof below.
pinging some Stylus devs for feedback.
@eight04 @mottie
try it in windows chrome. i works only on the left corner of the button. 80% of the space of that tab does not work. if i double click on that non working area it selects the wan ip information text on the top right corner.
I tried it on Chrome Version 91.0.4472.114 (Official Build) (64-bit) with Linux 5.12.18-amd64-desktop and works very nice... sorry about gif low quality... but havn't figured out how you change these colors... yet :)
i just tried it with windows and in windows it doesnt work. btw. i found a way to convert the stylus code straight to dd-wrt compatible css code. easy task. just dumped it from the chrome dev menu since stylus just injects a css element and nothing else
great news!! maybe ddwrt members could propose "styles" to be included in official ddwrt builds... and contribute this way... On lichess.org members makes these styles for chess pieces and dev sometimes include these...
i just tried it with windows and in windows it doesnt work.
I think I see the issue, its only visible in chrome and when the style option to display theme name/version is enabled.
Please disable show style details as follows
I will dig deeper into this and make the option not default to start with because google chrome is being a ****
btw. i found a way to convert the stylus code straight to dd-wrt compatible css code. easy task. just dumped it from the chrome dev menu since stylus just injects a css element and nothing else
yes I did describe that method above
https://github.com/style-it-themes/dd-wrt-inspired-themes/issues/1#issuecomment-912430346
However whatever colors/options you have seleted is what the end result will be using that method. So for every color/settings you have a different compiled CSS, make sense?
However you will need more than just that stylesheet for full effect you need the stylesheet for OID search/speedchecker and so on, else those areas wont be styled.
So you will be missing at least iplookup stylesheet/speedchecker/oidsearch and these stylesheets will only compile if Im not mistaken when you are in respective tabs
great news!! maybe ddwrt members could propose "styles" to be included in official ddwrt builds... and contribute this way... On lichess.org members makes these styles for chess pieces and dev sometimes include these...
Using the method of grabbing the stylesheets as compiled, they will be much MUCH bigger than any of the existing css. Just for main areas you have 55KB alone this is without the stylesheets for iplookup stylesheet/speedchecker/oidsearch
So that will add some weight.
I would rather that the complete style is added for all areas not just main because otherwise it breaks the end results.
i know. that only small differences are in between that. i will take care about this. now i'm just testing if everything works. step 2 is shrinking everything to death
@BrainSlayer fixed issue https://github.com/style-it-themes/dd-wrt-inspired-themes/commit/7e803731eff76d4766a4b98214e6fc515671ff8e
Theres two ways to update the style now (since you edited your style to add your IP) the autoupdates are blocked.
1) force update style 2) re-edit IP's
or
1) copy and paste fix into the same area
step 2 is shrinking everything to death
hahaha, Im ok with death as long as it doesn't kill the quality. All images in base64/svgs included are already optimized to death maybe a little more is possible, also, if you minify the css I think it will help some except it wont be human readable anymore, which is OK for the final purposes.
i simply removed the manipulated string. thats a bad idea anyway. i show the copyright information in the selection area for the stylus preset. you will see it when its done. i have already written the code and now i'm just tested it on my devices. auto updates shall not be permitted anyway for security reasons. i have to update the stylus compiled code manually once there is a new one out
ah btw. you can remove sputnik graphics etc. the company isnt existing anymore. i will remove it from dd-wrt as well
i simply removed the manipulated string. thats a bad idea anyway. i show the copyright information in the selection area for the stylus preset. you will see it when its done. i have already written the code and now i'm just tested it on my devices. auto updates shall not be permitted anyway for security reasons. i have to update the stylus compiled code manually once there is a new one out
For inclusion in dd-wrt I agree, for these purposes of 3rd party not really as everything is manipulated anyway.
Copyrights for the css need to be included also and license which is MIT
@brainslayer
Also these are not to be referred to officially as stylus presets in any way shape or form, Stylus is a separate project Im unnafiliated with that, and this is my work, Stylus its an addon for the browser that facilitates such like projects like this one no more no less
https://svn.dd-wrt.com/changeset/47319 names all of them somename.stylus
'path src/router/kromo/dd-wrt/stylus`
should be
src/router/kromo/dd-wrt/dd-wrt-inspired-themes
styles names should be somename.dd-wrt-inspired-themes
This should be referred to as dd-wrt-inspired-themes if anything, please and thanks and the following added to the css headers, please.
## dd-wrt-inspired-themes
## © 2021 Style-it-themes - the-j0k3r
## License: MIT
## URL: https://github.com/style-it-themes/dd-wrt-inspired-themes
This commit https://svn.dd-wrt.com/changeset/47316
Should read `DD-WRT Inspired themes © 2021 Style-it-themes - the-j0k3r
https://svn.dd-wrt.com/changeset/47313
Not stylus. its dd-wrt-inspired-themes
https://svn.dd-wrt.com/changeset/47322
same, labels shouldn't read stylus at all.
and so on and so forth. Thank you
ah btw. you can remove sputnik graphics etc. the company isnt existing anymore. i will remove it from dd-wrt as well
Sure, will do when its official, you can also update the remaining logos for hotspots with the provided ones from here, however wifidog logo is only for dark styles, light styles need a different image to be readable. Currently all the default logos are indeed yuk. I see someone tried to submit new ones but never went anywhere.
@BrainSlayer ping above edits =) thanks for understanding.
but you know that these are just folder names which are totally invisible in the firmware. so dont be pedantic by forcing overlong folder names in my dev tree.
and dashes are not allowed in variable names. i use the short variant. more important is the label which is shown in the gui and nothing else. and there is dd-wrt inspired styles and nothing else
the inspired styles string etc. you want is too long. it doesnt fit
latest version
@BrainSlayer
Dracula, Solarized Dark, etc is enough as names go, from options in select menu,
The correct name of the styles on select should be the same as the screenshot below.
Not solarized darker, its dark. this matters somewhat because it supposed to match with the syntax highlighting names.
by forcing overlong folder names in my dev tree.
We can shorten that by removing .stylus
from the theme names like
https://svn.dd-wrt.com/browser/src/router/kromo/dd-wrt/ddwrt_inspired_themes?rev=47343&order=name
Shouldnt the extension be CSS and not stylus?themename.css
is what is standard for browsers, .styl
is only recogized internally by the browser extension which you dont need or use.
Anyway I feel this request has been filled so will be closing soon.
I will make some updates to this theme so that by default the styling is as I prefer, since users cannot customize options.
Also note.
https://svn.dd-wrt.com/browser/src/router/kromo/dd-wrt/ddwrt_inspired_themes/dracula.stylus?rev=47343#L8 https://svn.dd-wrt.com/browser/src/router/kromo/dd-wrt/ddwrt_inspired_themes/dracula.stylus?rev=47343#L9
Can be removed from these, since there are no custom options to change fonts via the included dd-rwrt styles.
Lets see how it all looks in the end... Finally dd-wrt has pretty consistent styling everywhere. Until someone complains that theire internet explorer browser doesn't support half the css properties used.
Extra note
It would be a LOT LOT easier/faster and more efficient and make for smaller styles, just to change the :root values around and have a single static css files for these styles.
Thats how theming should be done via css in any case.
@BrainSlayer
Also the checkbox width and height should be .88rem
because that is what looks better atm youre using defaults which is way to big at 1rem
Ill make that default cause I wasnt intending to have these things fixed size without a way to change it after.
its no css. its css embedded html code which is generated. i choose the extension stylus since it was made with stylus and i need a unique file extension for implementing a file scanner. so the drop down menu gets automatic generated entries.
yes i know that just changing the root values would be enough. but only in theory. unfortunatly the style files differ also in other parts. but the internal fs compression does a good job. all files are 18kb in total
@BrainSlayer
Also the checkbox width and height should be
.88rem
because that is what looks better atm youre using defaults which is way to big at 1remIll make that default cause I wasnt intending to have these things fixed size without a way to change it after.
dont know what you mean. i did use the files as is. no modifications.
its no css. its css embedded html code which is generated. i choose the extension stylus since it was made with stylus and i need a unique file extension for implementing a file scanner. so the drop down menu gets automatic generated entries.
In that case please use .styl
this wasnt made with stylus, misconception.
Theres tow distinct stylus and only one is related here.
Stylus the browser extension
Stylus the programing language used on this project.
So .styl
is the actual extension like shown on
unfortunatly the style files differ also in other parts.
They shouldnt at all, if they do, theres going to be issues.
dont know what you mean. i did use the files as is. no modifications.
Here for instance.
https://svn.dd-wrt.com/browser/src/router/kromo/dd-wrt/ddwrt_inspired_themes/solarized_darker.stylus?rev=47343#L930 https://svn.dd-wrt.com/browser/src/router/kromo/dd-wrt/ddwrt_inspired_themes/solarized_darker.stylus?rev=47343#L931
its not modified. its default by stylus
its no css. its css embedded html code which is generated. i choose the extension stylus since it was made with stylus and i need a unique file extension for implementing a file scanner. so the drop down menu gets automatic generated entries.
In that case please use
.styl
this wasnt made with stylus, misconception.Theres tow distinct stylus and only one is related here.
Stylus the browser extension
Stylus the programing language used on this project.
So
.styl
is the actual extension like shown on
unfortunatly the style files differ also in other parts.
They shouldnt at all, if they do, theres going to be issues.
but they do. check it by yourself what stylus generates
its not modified. its default by stylus
Again with stylus, the default option dont come from stylus they come from this theme.
See
If I had some warning you were going to do this so fast commit into repo, I would have time to adjust the values and make an update, which is my intention because for official inclusion things have to be a certain way, else they will present issues in some cases
As is consider my suggestions it will offer best results across OS's font sizes etc.
Ill be making updates asap.
@BrainSlayer
in order to iron out the kinks here it is update 3.2.0 has been pushed. any css should be compiled from these.
Again please note the update procedures for your install of this theme as noted in the readme.
Theres two ways to update the style now (since you edited your style to add your IP) the auto-updates are blocked. this is by design thats outside our control/
1) force update style 2) re-edit IP's
or
1) Edit the style via the extension
2) copy and paste the changes into the same area as the commit above
On another note, do the theme files already include the speedchecker, oid, iplookup etc stylesheets?
I dont have time right now, but the css should be same for all styles.
I dont mind doing it if you dont mind waiting.
Earlier you said
unfortunatly the style files differ also in other parts.
Im unsure what differences these are, there should be 0 differences except the colors.
I can take requests for new color schemes to be added in individual new tickets please.
speedchecker and mac oid lookup etc are external sites. they cannot be modified from the os itself. for the 401 error site. first you are using outdated strings. the hint with the root login is not existing anymore since its 15 years old. people should know it now. additing a additional copyright string for the theme is not neccessary from my point of view. basicly i dont like that. it should be noted on a more special info place, but not on a functional page
and there is another bug. your style replaces 404 file not found with 401 authorization required
in addition the "info" character before this string is a invalid html character. use "ⓘ"
and just for your information. the 0,88rem checkbox size has no effect in chrome/windows
speedchecker and mac oid lookup etc are external sites. they cannot be modified from the os itself
Yes, there is that,
and there is another bug. your style replaces 404 file not found with 401 authorization required
My style, only styles the 401 page when you dont enter a password or valid password,
I would need to see what the differences between the dd-wrt css for both 401/404 pages before I can actually see what the issue is.
Im overriding the 401 page default dd-wrt css when this page is generated and hacking the redesign ontop of that css, not instead of.
So to some extent, this theme as is and the css needs to have a base framework that is used in order to be extended/modified For instance, you go and select the brainslayer built in theme, and then use this ontop, you will see it looks awful, thats because the brainslayer css differs a great deal for the blue ddwrt style.
I suspect by loading the compiled css from here the results wont be equal to using this project as 3rd party. But will see.
Now to try and generate a 404 page and see if the css that needs to be overriden is exact same only with different messages if it is, the only thing to do, if you insist on this course of action will be NOT to include the 401 page redesign/
and just for your information. the 0,88rem checkbox size has no effect in chrome/windows
Maybe some values need to be adding !important
so that they are loaded, if it does, easy fix.
the hint with the root login is not existing anymore since its 15 years old.
Well, this message existed when developed this theme and not 15 years ago, this was done 8 months ago, and then the message read the same.
Will fix though. I alwas thought it was silly to tell random ppl that probably tried to login and failed and are not the owner what the username for ssh was.
OK re 401 404
Yes, DD-WRT doesnt have specific 401/404 css, its just injects the page contents depending on 401/404
If you add a specific bg color for the 404 page, I can target them specifically as is Im picking at generic hardcoded values like [bgcolor="#cc9999"]
is commons to both pages.
see 404 what it allows me to pick at this is as I said.
So the bug is caused because as I said on https://github.com/style-it-themes/dd-wrt-inspired-themes/issues/1#issuecomment-912377668
DD-WRT uses a oversimplified number of CSS classes, I had to pick at other inline portion to be able to target specific portions in order to be able to distinguish between certain elements like e.g. this [name='add_button']:not([onclick*='_add']) a long dance is done all over this project to make this style possible.
Its not just classes, hardcoded colors makes doing a pure css style that looks good really hard, this is the reason behind for instace you load any built in style from dd-wrt choose dark, and not all areas of the style will be dark, e.g. help pages and other dialogs.
It was really not simple job and in order to improve and make styling with css, dd-wrt needs to add more specificity so anyone can style something specific without affecting the other. This was glossed over on my first post.
Unless you add different specificity, your option is NOT to include the 401 redesign.
From this style, the fix is easy in that case, first Ill make that option off as default, and add a readme not about the issue, since I cant change dd-wrt design, only you can, if in a hurry or wait until I can make contributions to dd-wrt to improve the limitations of the design.
and just for your information. the 0,88rem checkbox size has no effect in chrome/windows
for some reason no browser is respecting these settings anymore when lower than 1rem while using dd-wrt, it works for instance on my github style
I have no idea why this is, while inspecting values there is nothing showing up that overrides this in any manner.
More investigation needed.
I just tested these new styles within nightly ddwrt r47371... works smoothly... I like them very much ubuntu and matrix are great but for eveyday usage will stick with Material Darker... Thx BS and the-j0k3r for your great work.
i fixed the 401 issue by simply auto modifying the css content with the correct strings required
and just for your information. the 0,88rem checkbox size has no effect in chrome/windows
for some reason no browser is respecting these settings anymore when lower than 1rem while using dd-wrt, it works for instance on my github style
I have no idea why this is, while inspecting values there is nothing showing up that overrides this in any manner.
More investigation needed.
its windows. they use the standard checkbox model. you cannot compare this with linux all the time
i fixed the 401 issue by simply auto modifying the css content with the correct strings required
You fixed it for the built in styles or will I be able to style independent pages without conflict in this project. It would be nice if I could have something unique enough in some areas such as this so I can do targeted styling without conflicts, if its not done already, please, pretty please? just a different bg color would be enough or something else that unique enough.
Also I have a request of same nature for you dd-wrt, If you could add something unique enough for these two fieldsets
Overclocking/Gui style
This + the 401/404 pages would be of great assistance to me and this project.
its windows. they use the standard checkbox model. you cannot compare this with linux all the time
Its not Windows afaik, else, I wouldnt be able to make option work on my github style, the optionis dead for anything lower than 1rem
only on dd-wrt afaict, every other website this works perfectly. WHY idk. but it is what I observe.
I just tested these new styles within nightly ddwrt r47371... works smoothly... I like them very much ubuntu and matrix are great but for eveyday usage will stick with Material Darker... Thx BS and the-j0k3r for your great work.
@Mile-Lile
Im glad you like it, however a reminder, there are limitations in styling areas that the built in styles will never reach, so you will see some areas like speedchecker, oid, iplookup and other places that wont match the selected style.
This is a limitation of css styles because you cannot target specific domains, this limitation doesnt exist when using this project.
I will be testing the built in styles, to see how they differ and other details in specific dialogs/pages but of course I will never use the built in styles because of these limitations, I prefer consistent styling, and one of the main reasons why this project exists.
i fixed the 401 issue by simply auto modifying the css content with the correct strings required
You fixed it for the built in styles or will I be able to style independent pages without conflict in this project. It would be nice if I could have something unique enough in some areas such as this so I can do targeted styling without conflicts, if its not done already, please, pretty please? just a different bg color would be enough or something else that unique enough.
Also I have a request of same nature for you dd-wrt, If you could add something unique enough for these two fieldsets
Overclocking/Gui style
This + the 401/404 pages would be of great assistance to me and this project.
its windows. they use the standard checkbox model. you cannot compare this with linux all the time
Its not Windows afaik, else, I wouldnt be able to make option work on my github style, the optionis dead for anything lower than
1rem
only on dd-wrt afaict, every other website this works perfectly. WHY idk. but it is what I observe.
your styles will work anyway since they override it again. but its not possible to automodify the styles provided by the plugin since its injected without any care what the os does
I just tested these new styles within nightly ddwrt r47371... works smoothly... I like them very much ubuntu and matrix are great but for eveyday usage will stick with Material Darker... Thx BS and the-j0k3r for your great work.
@Mile-Lile
Im glad you like it, however a reminder, there are limitations in styling areas that the built in styles will never reach, so you will see some areas like speedchecker, oid, iplookup and other places that wont match the selected style.
This is a limitation of css styles because you cannot target specific domains, this limitation doesnt exist when using this project.
I will be testing the built in styles, to see how they differ and other details in specific dialogs/pages but of course I will never use the built in styles because of these limitations, I prefer consistent styling, and one of the main reasons why this project exists.
there is always a dirty trick to reach that approach. simply by giving the style as argument to the oid / speedchecker etc call and injecting it from the remote server. but rome wasnt build in one day. right?
there is always a dirty trick to reach that approach. simply by giving the style as argument to the oid / speedchecker etc call and injecting it from the remote server. but rome wasnt build in one day. right?
right! =)
When rome is built those areas, the specific css will be needed in addition. Not a big deal, its pretty simple to compile that sass to css, it may need other work this side.
your styles will work anyway since they override it again. but its not possible to automodify the styles provided by the plugin since its injected without any care what the os does
So its a definite no to adding specific classes/id's or something so I can target specific areas? Or is this like rome? =)
Will see only how 401/404it works when I upgrade the build that has all these changes upstream. I see breaking changes in the design of this style when that happens Im sure because Im targeting a generic area thats reused. To early to know for me.
Describe the feature you'd like
BS is willing to add it to ddwrt if you can covert it to css
Additional context
no additional context:)