search

styled-components / comparison

Comparing different ways to style components
MIT License
183 stars 23 forks source link

Remove direct dependency to jss, render global styles over react-jss #33

Closed kof closed 7 years ago

kof commented 7 years ago

What do you think is hacky about it?

kof commented 7 years ago

Except of global styles by definition being dirty.

mxstbr commented 7 years ago

Creating an empty component just to render global styles. With e.g. CSS modules that's a lot nicer since they just keep html, body etc. as global.

kof commented 7 years ago

Creating an empty component just to render global styles. With e.g. CSS modules that's a lot nicer since they just keep html, body etc. as global.

Ok, fixed. Now you can think of it as of Container component.

kof commented 7 years ago

So are we good here?