search

styled-components / jest-styled-components

🔧 💅 Jest utilities for Styled Components
MIT License
1.58k stars 144 forks source link

add support for @starting-style #446

Open jantimon opened 1 month ago

jantimon commented 1 month ago

What:

Upgraded the @adobe/css-tools dependency to include the fix for parsing the @starting-style CSS feature, which was causing a "missing '}'" error.

Why:

The current version of @adobe/css-tools used by jest-styled-components fails to parse the @starting-style CSS feature, resulting in a parsing error. The upgrade includes a fix for this issue, allowing for the correct parsing of CSS files using @starting-style.

How:

The changes were implemented by updating the package.json file to use the latest version of @adobe/css-tools, which includes the fix from the PR I submitted to @adobe/css-tools (https://github.com/adobe/css-tools/pull/323).

Additional Comments:

Unfortunately, I could not add a test case for the @starting-style feature because jsdom 20 uses CSSOM for CSS parsing, which also has a similar issue. I submitted a PR to fix this issue in CSSOM (https://github.com/rrweb-io/CSSOM/pull/1), but the latest version of jsdom cannot be merged into jest-environment-jsdom to maintain Node 16 support.

For reference, I have already submitted a similar PR to testing-library/jest-dom addressing the same issue: https://github.com/testing-library/jest-dom/pull/602.