styled-components / polished

A lightweight toolset for writing styles in JavaScript ✨
https://polished.js.org/
MIT License
7.64k stars 208 forks source link

Fail to parse hsl(89.99999999999999,100%,50%) #343

Closed jean343 closed 6 years ago

jean343 commented 6 years ago

Mixin/Helper/Shorthand you were using and how you were using it:

var polished = require("polished")
polished.parseToHsl("hsl(90.999999, 100%, 50%)");

What you are seeing:

Couldn't parse the color string. Please provide the color as a string in hex, rgb, rgba, hsl or hsla notation.

What you expected to see: I was expecting decimals in hue to be parsed as numbers. I am passing color strings from another library, and they are in the form: hsl(90.999999, 100%, 50%).

Reproduction: https://runkit.com/embed/cd7ptn0l2jyl

Thanks!!

bhough commented 6 years ago

@jean343 thanks for the issue. We were able to confirm it and are currently working on a fix now that 2.0 is out.

jean343 commented 6 years ago

Thanks!!

mxstbr commented 6 years ago

:tada: This issue has been resolved in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: