styled-components / polished

A lightweight toolset for writing styles in JavaScript ✨
https://polished.js.org/
MIT License
7.6k stars 209 forks source link

fix: Add additional files and folders to npmignore #553

Closed scttcper closed 3 years ago

scttcper commented 3 years ago

Currently, this module is 9mb on disk. Added a bunch of stuff to .npmignore so that they aren't published.

Can check unpacked size via npm https://www.npmjs.com/package/polished image

codecov[bot] commented 3 years ago

Codecov Report

Merging #553 (1dbbca8) into main (2b83397) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           88        88           
  Lines          831       831           
  Branches       305       305           
=========================================
  Hits           831       831           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b83397...0661138. Read the comment docs.

bhough commented 3 years ago

Thanks for putting this together @scttcper. We will review, but the docs have been an often requested inclusion for offline access: https://github.com/styled-components/polished/issues/281

scttcper commented 3 years ago

@bhough kept docs in there. The biggest issue is the .yarn folder which i assume is some sort of cache. Docs is maybe 2mb

bhough commented 3 years ago

@bhough kept docs in there. The biggest issue is the .yarn folder which i assume is some sort of cache. Docs is maybe 2mb

@scttcper That is a remnant of our work in the background to move to Yarn 2. We are taking the zero-install approach with polished once we swap and that folder is where it stores the cache. However, we can remove it for now.