Closed mansona closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
version-4-1-1@99fb4a1
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## version-4-1-1 #567 +/- ##
=================================================
Coverage ? 100.00%
=================================================
Files ? 89
Lines ? 846
Branches ? 309
=================================================
Hits ? 846
Misses ? 0
Partials ? 0
Flag | Coverage Ξ | |
---|---|---|
unittests | 100.00% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 99fb4a1...33de0fb. Read the comment docs.
Hi @mansona, author of the Scarf package here. From the description for the PR, I just wanted to clarify a few points because it seems there may be some misunderstandings here. I described this a bit in another thread that I happened to see first (https://github.com/styled-components/polished/pull/559#issuecomment-780791004) but to summarize here:
cc @bhough
I hope you'll consider resuming the use of Scarf in this project, but either way, thanks for all of your open-source work and thanks for your time! :)
Hey folks π
I'm just opening up this PR to remove the
@scarf/scarf
analytics package from polished.I don't want to get into too much of a philosophical conversation about analytics or ethics but I would say that the package is potentially a GDPR violation (as it does not work on an opt-in basis) and there are some serious problems with the implementation of scarf as it currently doesn't allow you opt-out if you are using yarn https://github.com/scarf-sh/scarf-js/issues/3
Cheers!