styled-components / styled-components-website

The styled-components website and documentation
https://styled-components.com
MIT License
612 stars 436 forks source link

Refactor Question: Should we bust out the Styles and Import them? #911

Open brnt-toast opened 1 year ago

brnt-toast commented 1 year ago

Currently auditing pages/index.js (getting ready to migrate over to TS) and noticed that i folded about 13 styles before to getting the render function.

At this point would it make sense to externalize the styles and import them? Other pages aren't so bad except pages/showcase.js.

Most of the components in components/ aren't bad either except for maybe a few like components/SmallShowcase/index.js

Personally I vote, yes due to the increase readability.

I would slowly work on this during my free time and the TS rewrite.