styled-components / stylis-plugin-rtl

↔️ stylis RTL plugin based on CSSJanus
MIT License
37 stars 18 forks source link

/* @noflip */ doesn't work. #16

Closed tamirhal closed 4 years ago

tamirhal commented 4 years ago

Hi, I want to exclude CSS rule from being manipulated by the stylis-plugin-rtl plugin/StyleSheetManager I tried that:

/* @noflip */
.stx_yaxis {
  /* y-axis price styles */
  direction: ltr !important;
}

still doesn't work, it's still changing the direction to rtl I also opened a thread in cssjanus but in their demo its working fine.

https://github.com/cssjanus/cssjanus/issues/84

this is from package-lock

    "stylis-plugin-rtl": {
      "version": "1.1.0",
      "resolved": "https://registry.npmjs.org/stylis-plugin-rtl/-/stylis-plugin-rtl-1.1.0.tgz",
      "requires": {
        "cssjanus": "^1.3.0"
      }
    }
    "styled-components": {
      "version": "5.1.1",
      "resolved": "https://registry.npmjs.org/styled-components/-/styled-components-5.1.1.tgz",
      "requires": {
        "@babel/helper-module-imports": "^7.0.0",
        "@babel/traverse": "^7.4.5",
        "@emotion/is-prop-valid": "^0.8.8",
        "@emotion/stylis": "^0.8.4",
        "@emotion/unitless": "^0.7.4",
        "babel-plugin-styled-components": ">= 1",
        "css-to-react-native": "^3.0.0",
        "hoist-non-react-statics": "^3.0.0",
        "shallowequal": "^1.1.0",
        "supports-color": "^5.5.0"
      }
    }
marcuslindfeldt commented 4 years ago

👍 It would be great if this could be fixed. Current workaround is to intentionally set the reverse position if [dir="rtl"] so that the plugin flips it into the correct position. Feels hacky though.

onzag commented 1 year ago

Still doesn't work as of 2022.