search

styled-components / typescript-styled-plugin

TypeScript server plugin that adds intellisense to styled component css strings
MIT License
76 stars 7 forks source link

Set `isIncomplete` flag on completion item in addition to in the metadata #8

Closed mskelton closed 1 year ago

mskelton commented 1 year ago

isIncomplete is currently being set on the metadata for the completion items from Emmet, but this doesn't work when using Neovim with nvim-cmp which looks for isIncomplete on the actual completion item, rather than in the metadata.

The field is available in the TS definition for ts.CompletionInfo so this seems like an acceptable change.

jasonwilliams commented 1 year ago

Thanks for your contribution, ill look into merging this once the situation with https://github.com/microsoft/TypeScript/issues/51713#issuecomment-1493053367 is dealt with

mskelton commented 1 year ago

@jasonwilliams Any news on getting this PR merged?

jasonwilliams commented 1 year ago

Hey @mskelton is there a reason you closed this?

mskelton commented 1 year ago

@jasonwilliams It had been sitting open unmerged for a long while, and I don't even use this project anymore, so I was just doing some housekeeping. I can reopen if you want to merge it.

jasonwilliams commented 1 year ago

Ahh ok thanks, no it’s fine, if we don’t have people to test it it will be hard to merge.

apologies for forgetting about this PR, I don’t use Styled Components anymore and have struggled to get maintainers to replace me.

so let’s keep it closed until someone else wants it open.