styled-components / vim-styled-components

Vim bundle for http://styled-components.com based javascript files.
300 stars 24 forks source link

Think the `css` function's template strings aren't considered for styling #14

Closed jikkujose closed 7 years ago

jikkujose commented 7 years ago

Edit (by fleischie):

Hey fleischie, thanks for your hard work! :100:

I found an issue regarding the highlighting of specific keywords of the styled-components module. See the attached screenshot: The css tagged template literal leads to an inconsistently highlighted content.

I would appreciate some pointers or any hints on how to fix/bypass this. :bowing_man:

Original description: screen shot 2017-03-20 at 11 03 17 am

fleischie commented 7 years ago

Sorry @JikkuJose I cannot reproduce the above behavior.

Maybe you can provide some more information on what your working environment is: OS, vim-flavor, etc.

Also does pad and/or shadow contain semi-colons? Because I might suspect the missing ; to cause problems later on. (Although only when not after a }...) I might consider looking into it, when I have time to fix the overall styling issues in #3 , #9 and #13 .

jikkujose commented 7 years ago

Environment info:

Vimrc

.vimrc (shared for Neovim too)

Source

Styles.js

fleischie commented 7 years ago

Do you use the latest version of this plugin? I cannot reproduce the issue you are describing above with my develop version (which is also the current master).

Technically, I don't include anything specific in the namespace to handle as styled-component's tagged template literals. I just check, whether styled-components is in the file and handle every template string as a container for css-syntax.

I furthermore cannot determine, whether there is a incompatability with another vim plugin you're using. If you can poke around some more and check, when and where exactly it breaks. I can better check, whether there is something I can do.

fleischie commented 7 years ago

Closing, because:

  1. Inactivity, and
  2. cannot reproduce.