search

styled-components / vim-styled-components

Vim bundle for http://styled-components.com based javascript files.
300 stars 24 forks source link

Add support for Emotion #25

Closed colepeters closed 7 years ago

colepeters commented 7 years ago

Hello! Thanks for the plugin. This is a tiny PR to add support for Emotion, since it uses essentially the same signature as styled-components and similar.

I’ve tested this locally (macOS, NeoVim 0.2.0) to ensure syntax highlighting and indentation work as expected.

image

colepeters commented 7 years ago

Just to note, I've noticed some weird behaviour with syntax highlighting on particular properties and values/keywords. Note border-radius in the example below:

image

Some properties (like appearance above) seem to take on unique colours, as do some values (transparent compared to none or inherit, etc, again shown above). Not sure if this is intentional?

(This highlighting pattern occurs regardless of which colourscheme I have loaded. I don't have any CSS syntax plugins, but I don't think that's the issue as CSS normally highlights fine for me?)

EDIT: Looks like this is the same behaviour as discussed in #23.

fleischie commented 7 years ago

Thank you so much for this PR. 🙇 I took your PR as a base to simplify the setup of the API-support block.

As for the highlighting issues: The way CSS is structured and the way vim highlights it's syntax is not 💯% working 👌 together. This has something to do with prioritization of rules, etc. I know of this and will hopefully eventually have a solution to this, but yeah, let's see. 😊

colepeters commented 7 years ago

Nice one! Glad this was helpful.