search

styled-components / vim-styled-components

Vim bundle for http://styled-components.com based javascript files.
300 stars 24 forks source link

Fix example variable name #34

Closed lewiscowper closed 6 years ago

fleischie commented 6 years ago

Sorry for taking so long to respond: Why is this change necessary? Can you give more insights, on why you did this change?

lewiscowper commented 6 years ago

Hi @fleischie, no problem at all for the time, either I've misunderstood it as a failing example (because mainStyles is pulled from elsewhere), or there's an inconsistency in the example.

mainTheme is being defined as a tagged template literal, but it's never used.

Then the styled-component being generated uses mainStyles, which is undefined.

If that's the intention, then feel free to close and ignore the PR, but if it's not, then these changes will fix what I think is an inconsistency in the example failing cases.

On a side note, thanks for all your work on this plugin, it's excellent and I use it daily! :+1: :100: :)

fleischie commented 6 years ago

Yeah, great catch. I had to work hard to see, that I mistyped the variable name. 😛