Causes conflicts with vim-jsx-pretty: cannot disable on tsx

styled-components / vim-styled-components

Vim bundle for http://styled-components.com based javascript files.

300 stars 24 forks source link

Causes conflicts with vim-jsx-pretty: cannot disable on tsx #76

Closed pappasam closed 3 years ago

pappasam commented 4 years ago

See https://github.com/MaxMEllon/vim-jsx-pretty/issues/124

Basically, syntax/typescript.vim automatically loads syntax/javascript.vim, preventing the configuration option g:vim_jsx_pretty_disable_tsx from working. I've stopped relying on this plugin, but since vim-jsx-pretty is a popular library, it might be a good idea to fix this issue at some point.

stevematney commented 3 years ago

This should be resolved on the develop branch.

CallumHoward commented 3 years ago

This was working fine for me up until a few weeks ago with vim-jsx-pretty and vim-styled-components.

Now if I source vim-styled-components first I get errors and the styled components syntax highlighting doesn't work.
If I source it after vim-jsx-pretty there are no errors but still no syntax highlighting on styled components.

I'm testing with .tsx files and the filetype in Neovim is reported as typescript.tsx