Limiting the scope of plugin files.

styled-components / vim-styled-components

Vim bundle for http://styled-components.com based javascript files.

300 stars 24 forks source link

Limiting the scope of plugin files. #80

Closed stevematney closed 3 years ago

stevematney commented 3 years ago

Previously, we were loading all known javascript files for anything not specifically javascript. Now, we're only referencing the specific plugin files we intend to reference for syntax highlighting and indentation in styled-components. This should resolve any conflicts with other plugins.

Using source instead of runtime! (which pulls in every known javascript.vim file for after/indent/ftplugin/etc).
Resolves #73
Resolves #74
Resolves #75
Resolves #76

stevematney commented 3 years ago

Just to explain a bit on why this fix works: source allows us to read one specific file, which seems to be the intention of the previous runtime calls. The previous calls were doing much too broad of a search, and incidentally pulling in all the javascript syntax/indent/etc files from every plugin (including vim-styled-components) for all non-js filetypes (as described in the runtime help docs). This is why there were so many conflicts with other plugins.

fleischie commented 3 years ago

I unfortunately don't have the time/energy/...desire(?) to test this fully, so I suggest I merge this branch and let the potential issues flow in...

Also you are aware, that now with two merged PRs you are the most likely candidate to become the maintainer of this project? (Slightly joking, but not really. 😅 )