styled-components / webstorm-styled-components

styled-components highlighting support in IntelliJ editors
https://plugins.jetbrains.com/plugin/9997-styled-components
MIT License
375 stars 19 forks source link

Fix plugin not working with 2019.3 EAP builds #73

Closed undeadcat closed 5 years ago

undeadcat commented 5 years ago

MultiHostRegistrarImpl was a deprecated API, should have migrated away from it earlier. Now it seems the working implementation was deleted in 2019.3.

Use com.intellij.lang.javascript.injections.StringInterpolationErrorFilter, it was adapted from this plugin.

Fixes #72

undeadcat commented 5 years ago

@mxstbr, Is it possible to give @denofevil permissions to review and merge PRs in the plugin repo? I'm not able to add him as a reviewer or add him to any of the teams.

I'm going to be less involved in the plugin in the future and Dennis has contributed to it already and is the WebStorm team lead.

wijskinner commented 5 years ago

Quick work! Thanks.

undeadcat commented 5 years ago

@prigara, Will you publish a new version as well? I don't have publish rights any more.

Thank you!

denofevil commented 5 years ago

@undeadcat thanks for the fix! I've uploaded the new version