styled-components / xstyled

A utility-first CSS-in-JS framework built for React. 💅👩‍🎤⚡️
https://xstyled.dev
MIT License
2.28k stars 105 forks source link

Various refactoring & typing improvements #226

Closed gregberge closed 3 years ago

gregberge commented 3 years ago

Fix #180 Fix #163

codecov[bot] commented 3 years ago

Codecov Report

Merging #226 (b171461) into next (e889919) will increase coverage by 0.58%. The diff coverage is 97.31%.

:exclamation: Current head b171461 differs from pull request most recent head a7ee171. Consider uploading reports for the commit a7ee171 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             next     #226      +/-   ##
==========================================
+ Coverage   91.97%   92.56%   +0.58%     
==========================================
  Files          58       59       +1     
  Lines        1047     1062      +15     
  Branches      190      191       +1     
==========================================
+ Hits          963      983      +20     
+ Misses         83       78       -5     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/colorModes.tsx 93.33% <ø> (ø)
packages/core/src/customProperties.ts 100.00% <ø> (ø)
packages/core/src/transform.ts 100.00% <ø> (ø)
packages/emotion/src/preflight.tsx 100.00% <ø> (ø)
packages/emotion/src/styled.ts 100.00% <ø> (ø)
packages/emotion/src/x.ts 100.00% <ø> (ø)
packages/styled-components/src/createX.ts 100.00% <ø> (ø)
packages/styled-components/src/styled.ts 100.00% <ø> (ø)
packages/system/src/defaultTheme.ts 100.00% <ø> (ø)
packages/emotion/src/breakpoints.ts 50.00% <80.00%> (+50.00%) :arrow_up:
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e889919...a7ee171. Read the comment docs.

agriffis commented 3 years ago

You're inspiring me to actually learn TypeScript :stuck_out_tongue_winking_eye:

gregberge commented 3 years ago

You're inspiring me to actually learn TypeScript 😜

Ahah I don't like it but I don't have really the choice. xstyled is not easy to type!