Add overscrollbehavior xy - Githubissues

styled-components / xstyled

A utility-first CSS-in-JS framework built for React. 💅👩‍🎤⚡️

https://xstyled.dev

MIT License

2.28k stars 105 forks source link

Add overscrollbehavior xy #269

Closed SpencerDuball closed 3 years ago

SpencerDuball commented 3 years ago

Summary

Fixes #268

This adds overscrollBehaviorX, overscrollBehaviorY, the associated docs for these new props, and one typo fix on the /docs/overscroll-behavior/ page.

Changes:

Adds overscrollBehaviorX to layout
Adds overscrollBehaviorY to layout
Adds docs for overscrollBehaviorX and overscrollBehaviorY to /docs/overscroll-behavior
Fixes typo on /docs/overscroll-behavior where "Contain" is the section heading twice, instead of "Contain" and then "None"

Test plan

This is a small change, please see packages/system/src/styles/layout.ts: added the same code as overscrollBehavior but for overscrollBehaviorX and overscrollBehaviorY.

Successful website build:

website_build_output

Successful website video:

https://user-images.githubusercontent.com/22606045/120120213-78f14b80-c161-11eb-9049-792ed1e8eaf0.mov

Successful package build:

package_build_output

Successful package test:

package_test_output

Successful package lint (note there are 57 warnings, these warnings exist prior to this PR):

package_lint_output

netlify[bot] commented 3 years ago

Deploy request for xstyled accepted.

Name	Link
Latest commit	5b884d44a66f64c8a0733293c27f6cabedbc2eb9
Latest deploy log	https://app.netlify.com/sites/xstyled/deploys/60b3ff46de98d20008911ce2

SpencerDuball commented 3 years ago

Closing as #268 was closed in favor of extending XStyled on an as needed basis: https://xstyled.dev/docs/adding-new-utilities/