search

styled-components / xstyled

A utility-first CSS-in-JS framework built for React. 💅👩‍🎤⚡️
https://xstyled.dev
MIT License
2.27k stars 107 forks source link

Add support for margin-inline-* properties #325

Closed quantizor closed 2 years ago

quantizor commented 2 years ago

🚀 Feature Proposal

CSS has added some style rules for adding margin based on logical block position in bidi scenarios.

Would be good to get this implemented into xstyled for both normal styled composition and as a prop.

agriffis commented 2 years ago

It's a new day, but still, for historical perspective see #210

quantizor commented 2 years ago

Fair enough! Most websites probably won't need this so happy to defer to extension to support more enterprise-y use cases.

agriffis commented 2 years ago

@probablyup To be clear, I wasn't trying to shut you down. My guess is this could be revisited if it makes sense. Just rang a bell in my mind, I knew I'd seen this before.

gregberge commented 2 years ago

Yeah I think we could propose an official i18n extension that supports this, but it does not make sense in the core.