styled-components / xstyled

A utility-first CSS-in-JS framework built for React. 💅👩‍🎤⚡️
https://xstyled.dev
MIT License
2.27k stars 107 forks source link

🐞fix(emotion): support ESM for createX #338 #343

Closed xcfox closed 2 years ago

xcfox commented 2 years ago

Summary

support ESM for createX in @xtyled/emotio, and fix #338 It may be a mistake in https://github.com/gregberge/xstyled/commit/292fe28d71c280cb755ed4ecf01ac6deae693031.

Test plan

Previous output code in dist/index.esm.js use emStyled directly:

...
const createX = (generator) => {
  const styled = createBaseStyled(createCssFunction(generator), generator);
  const x = {};
  Object.keys(emStyled).forEach((tag) => {
    x[tag] = styled(tag)``;
  });
  return x;
};
...

After fix:

...
const createX = (generator) => {
  const styled = createBaseStyled(createCssFunction(generator), generator);
  const x = {};
  Object.keys(emStyledInterop).forEach((tag) => {
    x[tag] = styled(tag)``;
  });
  return x;
};

...
gregberge commented 2 years ago

Fixed in #342