styleguidist / react-styleguidist

Isolated React component development environment with a living style guide
https://react-styleguidist.js.org/
MIT License
10.84k stars 1.44k forks source link

posibility of a 11.1.8 release with less strict webpack-dev-server version dependency #1880

Closed bestrivens001 closed 2 years ago

bestrivens001 commented 3 years ago

Hi, @sapegin,

Issue Description

I noticed that a vulnerability is introduced in react-styleguidist@11.1.7: Vulnerability CVE-2020-28469 affects package glob-parent (versions:<5.1.2): https://snyk.io/vuln/SNYK-JS-GLOBPARENT-1016905 The above vulnerable package is referenced by react-styleguidist@11.1.7 via: react-styleguidist@11.1.7 ➔ webpack-dev-server@3.11.2 ➔ chokidar@2.1.8 ➔ glob-parent@3.1.0

Since react-styleguidist@11.1.7 (19,010 downloads per week) is referenced by 27 downstream projects (e.g., vue-styleguidist 4.41.0 (latest version), vue-cli-plugin-styleguidist 4.41.0 (latest version), @irvingjs/styleguide 6.1.0 (latest version), @comicrelief/component-library 5.3.0 (latest version), create-react-styleguide 7.0.1 (latest version)), the vulnerability CVE-2020-28469 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths: (1)@comicrelief/component-library@5.3.0 ➔ react-styleguidist@11.1.7 ➔ webpack-dev-server@3.11.2 ➔ chokidar@2.1.8 ➔ glob-parent@3.1.0 (2)@irvingjs/styleguide@6.1.0 ➔ react-styleguidist@11.1.7 ➔ webpack-dev-server@3.11.2 ➔ chokidar@2.1.8 ➔ glob-parent@3.1.0 ......

If react-styleguidist@11.1.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from react-styleguidist@11.1.7 ?

Fixing suggestions

In react-styleguidist@11.1.8, maybe you can kindly try to perform the following upgrade : webpack-dev-server ^3.11.0 ➔ ^4.0.0;

Note: webpack-dev-server@4.0.0(>=4.0.0-beta.0) transitively depends on glob-parent@5.1.2 which has fixed the vulnerability CVE-2020-28469.

Thank you for your attention to this issue and welcome to share other ways to resolve the issue.^_^

sapegin commented 3 years ago

Feel free to send a pull request!

stale[bot] commented 2 years ago

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.