Open sapegin opened 8 years ago
Is this change still desired? I'd like to contribute and I'm looking for an easy place to start.
@natearn Yes, please do it! Feel free to ping me on Gitter if you have any questions ;-)
@sapegin Hi, where do you want to add this "fork me" ribbon?
Hide path line if it’s empty.
I think it's done, could we make this checkbox checked?
@snmslavk I think a new option in style guide config would work:
ribbon: {
url: 'http://example.com/',
text: 'Fork me on GitHub', // Default if the ribbon option passed
color: '#fff', // Default if the ribbon option passed
background: '#24292e' // Default if the ribbon option passed
}
You can use this CSS as a starting point:
@sapegin are all tasks done? if not i would like to pick one
@M-ZubairAhmed Only checked ones are done. And there’s an abandoned PR for the ribbon.
What I would love to have is to have some way to configure example both per example (maybe in a way the static
keyword is done? i.e. in the first line after the language), and per section (so we could have one style of example in one part of docs, and another — at another).
Things I would like to configure:
<div>
s.You can do it with showCode
modifier, or { "showCode": false }
.
Any ideas on the API?
That’s for plugins ;-)
It would be very hard to get rid or them, if possible. What’s the issue here?
Was that mentioned somewhere in the docs? If so, I have completely missed it :) Also, are all of the options that are available for configuration in styleguid.config.js
could be used this way or just a subset?
Hmm, I'd need to think more about it, but it would be nice to have a way to register the different layout components as an object with different keys probably? And then use them as value of a new layout
option?
Proooobably, yeah.
Just minor annoyance that when you need to have side-by-side comparison of two components in one example, right now we need to use that <div></div>
that would be there in the CODE
. What are the difficulties there? I think React allows to return arrays of components, and if you'd write an example like this:
[
<strong>aaa</strong>,
<em>bbb</em>
]
If would render it without problem. So maybe there'd be a way to either wrap examples that return multiple components in arrays? As they don't work already, I don't think it would break anything if some of the examples that throw error now would actually render sometimes :)
Looks like no :-( Would be nice to fix that.
Yeah, something like that may work, we need to try something. Maybe something similar to CSS Grids? Not sure will be easy to use or implement ;-)
I’m going to release the very first draft to 6.1.0. It will be almost useless, but you’ll be able to try and tell me what’s missed ;-)
Do you mean a div
that you have to use in examples to wrap multiple components or div
s that Styleguidist adds around your examples (there are two or three of them)? If you mean the former than we can fix that but we’ll have to think about backward compatibility with React 15 because returning arrays is a new feature of React 16.
Hi there, I would love to try and fix this issue, how did everyone else go about fixing it?
@catherinefromont That’s awesome! But I’m not sure what exactly are you asking. Do you have question about specific task?
Hey, I wanna try to go on with this issue. Can you explain a little more on the "New option, getComponentName(), to change the title." part? What is the general idea behind it? Or if that has already been discussed somewhere, be so kind to point me in that direction. Thanks!
@glebez The general idea is to be able to show anything instead of an actual component name in the style guide UI. I think #868 could be the first step, and the we'll need to split displayName
into two properties: actual component name, and name visible in the UI. So probably we don't need a separate option for that, but we'll still need to do some refactoring.
@sapegin Hey are all the issues resolved , If that's not the case , i would love to work on some
React Styleguidist could be awesome for documenting components, like this, but now it’s not.
New option,getComponentName()
, to change the title.@visibleName
JSDoc tag — #933Anything else? Any feedback?