Update configuration for ESM

stylelint / eslint-config-stylelint

Stylelint org's shareable config for eslint

MIT License

59 stars 9 forks source link

Update configuration for ESM #133

Closed ybiquitous closed 2 years ago

ybiquitous commented 3 years ago

Which issue, if any, is this issue related to?

Related to stylelint/stylelint#5291

Is there anything in the PR that needs further explanation?

We are moving to ESM on the stylelint/stylelint repo: stylelint/stylelint#5291 This update will be required for the migration.

Replace eslint-plugin-sort-requires with the core rule sort-imports
- This change may cause many importing changes...
Keep this package CommonJS still because ESLint does not seem to support ESM (see eslint/rfcs#9)

I think some changes may be controversial. Please give me feedback!

ybiquitous commented 3 years ago

I guess we don't need to merge and release this until we're ready to work on stylelint/stylelint#5291?

Surely, it seems good to try this unpublished change on stylelint/stylelint as below:

--- a/package.json
+++ b/package.json
@@ -165,7 +165,7 @@
     "benchmark": "^2.1.4",
     "common-tags": "^1.8.0",
     "eslint": "^7.25.0",
-    "eslint-config-stylelint": "^13.1.1",
+    "eslint-config-stylelint": "github:stylelint/eslint-config-stylelint#esm",
     "got": "^11.8.2",
     "husky": "^6.0.0",
     "jest": "^27.0.1",

Perhaps, we may want to update this ESLint configuration as we move forward with our ESM support.

ybiquitous commented 2 years ago

@jeddy3 I've created PR #143 to prepare the 14.0.0 release. Can I merge this PR?

jeddy3 commented 2 years ago

Yeah, might as well. Saves us having to release another version when we actually do the ESM migration.

ybiquitous commented 2 years ago

Thanks. I’ll proceed with the release of 14.0.0. 💪🏼