search

stylelint / stylelint-demo

The online demo on the Stylelint website
https://stylelint.io/demo/
MIT License
15 stars 8 forks source link

feat: deploy previews #260

Closed mattxwang closed 3 years ago

mattxwang commented 3 years ago

What is the problem you're trying to solve?

Currently, testing new PRs is a bit tricky - we'd have to clone locally and test, and I know from a few PRs that I've merged-in that our current CI setup doesn't cover the entire production-facing featureset.

What solution would you like to see?

It would be great if we could do a deploy preview for each pull request! Netlify has free deploy previews for pull requests, though this only works for static-ish websites (while the stylelint-demo also has a server). Unsure if there's a way we can do this efficiently with Heroku. Though, I'm not super familiar with the stack, so I may be missing something!

More than happy to look into this (since it's something I've had to do for my own projects / other nonprofit work), but curious to see what the rest of the stylelint team thinks!

jeddy3 commented 3 years ago

Good idea.

Heroku has Review Apps. I've created a pipeline and enabled Review Apps. Hopefully, it'll show up on the next pull request.

jeddy3 commented 3 years ago

Review apps are live.

See https://github.com/stylelint/stylelint-demo/pull/251 as an example

mattxwang commented 3 years ago

Review apps are live.

See #251 as an example

Super cool, thanks for the quick turnaround!

m-allanson commented 3 years ago

Nice!

If I ever get to finishing the 'stylelint in the browser' PR, we'd be able to simplify this repo a lot. It could possibly lead to removing this repo completely, and having the demo as 'just' another page on stylelint.io.