search

stylelint / stylelint-demo

The online demo on the Stylelint website
https://stylelint.io/demo/
MIT License
15 stars 8 forks source link

Downgrade `react` and `react-dom` to v16 #304

Closed ybiquitous closed 2 years ago

ybiquitous commented 2 years ago

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

This pull request aims to fix the package installation failure by react-simple-code-editor. See the CI log for details: 

npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^16.0.0" from react-simple-code-editor@0.11.0
npm WARN node_modules/react-simple-code-editor
npm WARN   react-simple-code-editor@"0.11.0" from the root project

https://github.com/stylelint/stylelint-demo/runs/6054431732?check_suite_focus=true#step:5:29

The pull request satya164/react-simple-code-editor#84 has been opened to fix the error, but unfortunately, it has not been merged yet.

Probably, we need to find an alternative.

ybiquitous commented 2 years ago

FYI.

$ npm v react-simple-code-editor version peerDependencies
version = '0.11.0'
peerDependencies = { react: '^16.0.0', 'react-dom': '^16.0.0' }